RFR (XXS) 8224790: Remove Xusage.txt file

[David Holmes]

Hi Dan,

Thanks for taking a look at this.

On 25/05/2019 11:11 pm, Daniel D. Daugherty wrote:
> On 5/25/19 1:49 AM, David Holmes wrote:
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8224790
>> webrev: http://cr.openjdk.java.net/~dholmes/8224790/webrev/
> 
> make/hotspot/gensrc/GenerateSources.gmk
>      No comments.
> 
> src/hotspot/share/Xusage.txt
>      Deleted file.
> 
> Thumbs up!
> 
> When I did a sanity check grep for Xusage.txt I was surprised that
> it "showed up" in binary files. For example:
> 
> Binary file 
> ./build/macosx-x86_64-normal-server-release/images/jdk/jmods/java.base.jmod 
> matches
> 
> Hopefully that's an artifact of the build process?!?!?

Yes, the make rules I deleted copy the "source" file into thje built JDK 
image.

Thanks,
David

> Dan
> 
> 
>>
>> Before Java 7 the Xusage.txt file was used to print the "java -X" help 
>> information in English. From Java 7 this information was provided in 
>> localised format by the launcher. The Xusage.txt file was not removed 
>> at the time because it was also used by the gamma launcher. But the 
>> gamma launcher was removed in java 8 - JDK-8008772. The information in 
>> Xusage.txt has become stale and incomplete (despite several edits post 
>> Java 7). It should just be removed.
>>
>> Also removed the build logic that copied the file into the JDK image.
>>
>> Thanks,
>> David
>