RFR: 8223678: Add Visual Studio Code workspace generation support (for native code)
Robin Westberg
robin.westberg at oracle.com
Wed May 29 13:52:22 UTC 2019
Hi Erik,
Thanks for taking a look!
> On 28 May 2019, at 15:52, Erik Joelsson <erik.joelsson at oracle.com> wrote:
>
> Hello Robin,
>
> Looks good.
>
> Adding of ide.md is very nice, but could you try to format it like testing.md and building.md in regards to line lengths? I believe we are trying for 80 chars in those to make them read reasonably in a standard editor.
Sure, did a bit of reflowing and updated some formatting in order to look more like the other .md files.
Webrevs:
- Full: https://cr.openjdk.java.net/~rwestberg/8223678/webrev.02/
- Inc: https://cr.openjdk.java.net/~rwestberg/8223678/webrev.01-02/
Best regards,
Robin
>
> /Erik
>
> On 2019-05-27 09:03, Robin Westberg wrote:
>> Hi all,
>>
>> Please review this change that adds build system support for generating a Visual Studio Code workspace configured for working with the JDK native code. It configures the default C/C++ IntelliSense Engine to allow code completion/navigation and similar features. It also configures two executable targets (gtestLauncher and java) that can be built and debugged from the IDE.
>>
>> The main target is "make vscode-project”, additional information can be found in doc/ide.[md|html].
>>
>> Issue:
>> https://bugs.openjdk.java.net/browse/JDK-8223678
>>
>> Webrev:
>> https://cr.openjdk.java.net/~rwestberg/8223678/webrev.01/
>>
>> Testing:
>> Manual testing on Linux, MacOS and Windows
>>
>> Thanks Erik Joelsson for taking a look at an earlier version of it!
>>
>> Best regards,
>> Robin
More information about the build-dev
mailing list