RFR 8193255: Root Certificates should be stored in text format and assembled at build time

[Weijun Wang]

Since I need to track all added, removed, updated files in that directory, I thought depending on the directory itself is more correct. If I use the FindFiles function, then if some files are removed the cacerts will not be rebuilt.

--Max

> On May 30, 2019, at 9:11 PM, David Holmes <david.holmes at oracle.com> wrote:
> 
> Hi Max,
> 
> Not a review :)
> 
> On 30/05/2019 11:01 pm, Weijun Wang wrote:
>> Please take a review at
>>    http://cr.openjdk.java.net/~weijun/8193255/webrev.00/
>> Please pay attention to the 1st 3 and the last 2 files. Others are PEM files for all certs inside the original cacerts.
>> There is one thing I cannot get correct. If I update the GenerateCacerts.java file and rerun make, the cacerts file is unchanged. I thought the following line
>>    $(GENDATA_CACERTS): $(BUILD_TOOLS) $(GENDATA_CACERTS_SRC)
>> means when when the tool is changed, GENDATA_CACERTS will be called.
> 
> I think you have set a dependency on the directory, not the files within it. If you look at make/gensrc/Gensrc-jdk.internal.vm.compiler.gmk for example you'll see this rule:
> 
> $(GENSRC_DIR)/_gensrc_proc_done: $(PROC_SRCS) $(PROCESSOR_JARS)
> 
> but PROC_SRCS is defined as
> 
> PROC_SRCS := $(filter %.java, $(call FindFiles, $(PROC_SRC_DIRS)))
> 
> which is all the .java files in the src directory.
> 
> David
> 
>> Thanks,
>> Max