RFR 8232880: Update test documentation with additional settings for client UI tooltip tests

Alexey Ivanov alexey.ivanov at oracle.com
Fri Nov 1 14:41:26 UTC 2019


Thank you, Dmitry!
The changes look good to me.

On 01/11/2019 13:09, Dmitry Markov wrote:
> Hi Alexey,
>
> I have updated the fix. Please find the new version here: 
> http://cr.openjdk.java.net/~dmarkov/8232880/webrev.03/
>
> Thanks,
> Dmitry
>
>> On 31 Oct 2019, at 16:27, Alexey Ivanov <alexey.ivanov at oracle.com 
>> <mailto:alexey.ivanov at oracle.com>> wrote:
>>
>> Hi Dmitry,
>>
>> 437 …by the operating system. …
>>
>> I'd modify the following text a bit:
>> To run the test correctly, the default global key shortcut should be 
>> disabled. Follow the steps above, and then deselect "Turn keyboard 
>> access on or off" property which is responsible for `CTRL + F1` 
>> combination.
>>
>> Does it sound clearer?
>> I'd not use backticks on the "Turn keyboard access on or off" because 
>> it's not something user is typing, nor is it a piece of code. Is the 
>> word “property” correct? Does “shortcut” or “option” fit better?
>>
>> I'd recommend adding quotes around the option to look for:
>> 448 in the right-side pane look for "Turn off Windows key hotkeys" 
>> and double click on it;
>>
>> Consider adding an empty line before this line
>> 450 Note: restart is required to make the settings take effect.
>> to make it a separate paragraph in HTML.
>>
>>
>> Regards,
>> Alexey
-- 
Regards,
Alexey



More information about the build-dev mailing list