<AWT Dev> RFR 8232880: Update test documentation with additional settings for client UI tooltip tests

Dmitry Markov dmitry.markov at oracle.com
Mon Nov 4 10:55:09 UTC 2019


Thank you, Magnus!

Dmitry

> On 4 Nov 2019, at 10:24, Magnus Ihse Bursie <magnus.ihse.bursie at oracle.com> wrote:
> 
> 
> 
> On 2019-11-03 16:38, Dmitry Markov wrote:
>> Alexey and Sergey, thank you for the approval!
>> I wonder whether it is enough or I need one more “+1” from build-folk.
> You really don't need it, but here you get one. :-)
> 
> I think it was good that you continued polish the addition. The latest version looks much better than the original suggestion!
> 
> /Magnus
>> 
>> Thanks,
>> Dmitry
>> 
>>> On 1 Nov 2019, at 20:58, Sergey Bylokhov <Sergey.Bylokhov at oracle.com <mailto:Sergey.Bylokhov at oracle.com>> wrote:
>>> 
>>> +1
>>> 
>>> On 11/1/19 7:41 am, Alexey Ivanov wrote:
>>>> Thank you, Dmitry!
>>>> The changes look good to me.
>>>> On 01/11/2019 13:09, Dmitry Markov wrote:
>>>>> Hi Alexey,
>>>>> 
>>>>> I have updated the fix. Please find the new version here: http://cr.openjdk.java.net/~dmarkov/8232880/webrev.03/ <http://cr.openjdk.java.net/~dmarkov/8232880/webrev.03/>
>>>>> 
>>>>> Thanks,
>>>>> Dmitry
>>>>> 
>>>>>> On 31 Oct 2019, at 16:27, Alexey Ivanov <alexey.ivanov at oracle.com <mailto:alexey.ivanov at oracle.com> <mailto:alexey.ivanov at oracle.com <mailto:alexey.ivanov at oracle.com>>> wrote:
>>>>>> 
>>>>>> Hi Dmitry,
>>>>>> 
>>>>>> 437 …by the operating system. …
>>>>>> 
>>>>>> I'd modify the following text a bit:
>>>>>> To run the test correctly, the default global key shortcut should be disabled. Follow the steps above, and then deselect "Turn keyboard access on or off" property which is responsible for `CTRL + F1` combination.
>>>>>> 
>>>>>> Does it sound clearer?
>>>>>> I'd not use backticks on the "Turn keyboard access on or off" because it's not something user is typing, nor is it a piece of code. Is the word “property” correct? Does “shortcut” or “option” fit better?
>>>>>> 
>>>>>> I'd recommend adding quotes around the option to look for:
>>>>>> 448 in the right-side pane look for "Turn off Windows key hotkeys" and double click on it;
>>>>>> 
>>>>>> Consider adding an empty line before this line
>>>>>> 450 Note: restart is required to make the settings take effect.
>>>>>> to make it a separate paragraph in HTML.
>>>>>> 
>>>>>> 
>>>>>> Regards,
>>>>>> Alexey
>>> 
>>> 
>>> -- 
>>> Best regards, Sergey.
>> 
> 




More information about the build-dev mailing list