RFR: JEP 367: Remove the Pack200 Tools and API

[Vicente Romero]

Hi,

I think I have covered all the proposed fixes so far. This is the last 
iteration of the webrev [1], all the current changes are in this one, 
the code hasn't been split into different webrevs. I'm also forwarding 
to build-dev as there are some build related changes too. The CSR for 
this change is at [2]

Thanks for all the comment so far,
Vicente

[1] http://cr.openjdk.java.net/~vromero/8234542/webrev.02/
[2] https://bugs.openjdk.java.net/browse/JDK-8234596



On 11/20/19 8:21 PM, David Holmes wrote:
> Correction ...
>
> On 21/11/2019 9:10 am, David Holmes wrote:
>> Hi Vicente,
>>
>> Not sure the best mailing list for this review ... jdk-dev may not be 
>> well monitored.
>>
>> Is there a separate review thread for the actual tool removal (jdk.pack) 
>
> I overlooked the removal of jdk.pack (scrolling too fast through the 
> webrev) - apologies.
>
> David
> -----
>
>> and build system changes?
>>
>> This removal seems okay, but I found one additional reference:
>>
>> ./src/utils/IdealGraphVisualizer/nbproject/project.properties:auxiliary.org-netbeans-modules-apisupport-installer.pack200-enabled=false 
>>
>>
>> Thanks,
>> David
>> -----
>>
>> On 21/11/2019 8:54 am, Vicente Romero wrote:
>>> Hi,
>>>
>>> I need a reviewer for the changes to remove pack200 and unpack200 
>>> from the JDK. The webrev with the removal is at [1]. This patch is 
>>> the "implementation" of JEP 367 [2]. The patch is basically removing 
>>> the Pack200 related APIs plus its implementation plus any reference 
>>> to it in other tools like `jar`. In the case of `jar`, Pack200 was 
>>> only used if the `-n` flag was passed to the tool. I have removed 
>>> the code that was executed when that flag was passed. I have also 
>>> removed all the tests for Pack200.
>>>
>>> Thanks,
>>> Vicente
>>>
>>> [1] http://cr.openjdk.java.net/~vromero/8234542/webrev.00/
>>> [2] https://bugs.openjdk.java.net/browse/JDK-8232022