RFR 8234697: Generate sun.security.util.math.intpoly classes during build

Weijun Wang weijun.wang at oracle.com
Tue Nov 26 00:42:38 UTC 2019



> On Nov 26, 2019, at 12:36 AM, Erik Joelsson <erik.joelsson at oracle.com> wrote:
> 
> Build change looks good.

Thanks.

One question: I see the output to stdout from FieldGen.java shown in build. Is it possible to hide it but still store the output in the log file?

I copied everything from CLDR_GEN_DONE but that one does not log anything actually.

I can remove all output too, not really important.

Thanks,
Max

> 
> /Erik
> 
> On 2019-11-22 18:59, Weijun Wang wrote:
>> Please review the change at
>> 
>>    http://cr.openjdk.java.net/~weijun/8234697/webrev.00/
>> 
>> The new lines in Gensrc-java.base.gmk mimics the one for CLDR_GEN_DONE at the beginning of the same file.
>> 
>> I changed the BigInteger parameter in the FieldParams constructor (the one not reading terms) to its HEX string form and is now using the inverse. This makes sure the strings appeared here are exactly the same as the one used in CurveDB.java. The generated source code is identical to before.
>> 
>> Other smaller changes made to FieldGen.jsh:
>> 
>> 1. Package name
>> 2. No more jshell, but now Java
>> 3. Input/output paths as args for main()
>> 4. White spaces, wrapping and indentation
>> 
>> Thanks,
>> Max
>> 




More information about the build-dev mailing list