RFR: 8234835 Use UTF-8 charset in make support Java code

Jonathan Gibbons jonathan.gibbons at oracle.com
Wed Nov 27 17:53:55 UTC 2019


fixuppandoc is notable because it reads generated files .. which 
presumably contain non-ASCII UTF-8 characters.

For the other files, it seems strange to force the use of a charset 
which is different from the charset of record for all our source files 
(i.e. US-ASCII).  I'm not saying that UTF-8 isn't a good choice, but it 
seems questionable to be inconsistent.

--Jon

On 11/27/19 9:04 AM, Dan Smith wrote:
> Please review this patch to make explicit use of the UTF-8 charset in build tools' IO code.
>
> JDK-8065704 changed the platform default to US-ASCII, so the intended effect of this change is to address a regression and restore the typical earlier behavior.
>
> My particular interest is in fixuppandoc, but it seems like we might has well patch all of this code to avoid relying on the platform default.
>
> http://cr.openjdk.java.net/~dlsmith/8234835/



More information about the build-dev mailing list