RFR: JDK-8065704 Set LC_ALL=C for all relevant commands in the build system

[Magnus Ihse Bursie]

On 2019-10-02 17:45, Martin Buchholz wrote:
> I recall years ago running into troubles with regex character ranges, 
> e.g.
> https://unix.stackexchange.com/questions/15980/does-should-lc-collate-affect-character-ranges
> but my build script wrapper has been setting LC_ALL=C for a long time,
> and I set LC_COLLATE=C in my normal use shell environment
Hah, that's a funny (i.e. very unexpected, and not particularly funny at 
all) side effect of localization. :) We're doing quite a lot of "a-z" in 
the build systems; we should probably change them to "[[:lower:]]".
> (do regular humans care deeply about getting localized collation order?)
But oh yes! I'd *hate* it for my åäö to be sorted anywhere but after 
xyz. Probably just as much as the Germans would hate to *not* have the 
ä, ö and ü sorted alongside the a, o and u. You're just having the 
perspective of privilege from US-ASCII being considered the universal 
default. ;-)

/Magnus
>
> On Wed, Oct 2, 2019 at 2:09 AM Magnus Ihse Bursie 
> <magnus.ihse.bursie at oracle.com <mailto:magnus.ihse.bursie at oracle.com>> 
> wrote:
>
>      From the bug report:
>     We should prefix LC_ALL=C for most, maybe all, tools we use when
>     building.
>
>     This probably means we should run "export LC_ALL=C" early in the
>     configure script as well.
>     ---
>
>     The fix itself is trivial. While I know we've had several issues
>     regarding localization, I could not find any specific instances
>     now that
>     I was looking for them. I searched JBS for a while but could not
>     dig up
>     anything that was reproducible. So, unfortunately, I have been
>     unable to
>     verify that this solves any actual problems. That being said, I
>     believe
>     this is a prudent fix that should have been in place long time
>     ago. But
>     if anyone can give me a concrete example that breaks so that I can
>     verify that this helps, please let me know.
>
>     Bug: https://bugs.openjdk.java.net/browse/JDK-8065704
>     WebRev: http://cr.openjdk.java.net/~ihse/JDK-8065704-LC_ALL/webrev.01
>
>     /Magnus
>