RFR 8232880: Update test documentation with additional settings for client UI tooltip tests
Erik Joelsson
erik.joelsson at oracle.com
Fri Oct 25 13:48:35 UTC 2019
No need for new webrev.
/Erik
On 2019-10-25 06:45, Dmitry Markov wrote:
> Thank you for the review, Erik!
> I will update the fix as you suggested before push if you do not mind.
>
> Thanks,
> Dmitry
>
>> On 25 Oct 2019, at 14:00, Erik Joelsson <erik.joelsson at oracle.com> wrote:
>>
>> Looks good. I would put in a "the" before "operating system".
>>
>> /Erik
>>
>> On 2019-10-25 03:27, Dmitry Markov wrote:
>>> Hello,
>>>
>>> Could you review the fix for jdk14, please?
>>>
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8232880 <https://bugs.openjdk.java.net/browse/JDK-8232880>
>>> webrev: http://cr.openjdk.java.net/~dmarkov/8232880/webrev.00/ <http://cr.openjdk.java.net/~dmarkov/8232880/webrev.00/>
>>>
>>> Some Client UI tests use the following key sequence to show/hide tooltip message: “CTRL” + “F1". However this key combination is reserved by operating system on OS X platform. As a results the tests fail.
>>> Test documentation should be updated with some notes regarding this.
>>>
>>> Thanks,
>>> Dmitry
>>>
More information about the build-dev
mailing list