RFR: 8233078 : fix minimal VM build on Linux ppc64(le)
Doerr, Martin
martin.doerr at sap.com
Tue Oct 29 11:53:22 UTC 2019
Hi Matthias,
thanks for fixing it. I have a few requests:
disassembler_ppc.cpp:
Please remove includes completely if no longer needed (instead of commenting out).
sharedRuntime_ppc.cpp:
I think it's better to remove the 2 align(InteriorEntryAlignment). Succeeding code is not performance critical.
stubGenerator_ppc.cpp:
Code should better be protected by #ifdef COMPILER2 than commenting out.
Otherwise, looks good to me.
Thanks,
Martin
From: Baesken, Matthias <matthias.baesken at sap.com>
Sent: Dienstag, 29. Oktober 2019 12:42
To: 'hotspot-dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>
Cc: 'build-dev at openjdk.java.net' <build-dev at openjdk.java.net>; Doerr, Martin <martin.doerr at sap.com>
Subject: RFR: 8233078 : fix minimal VM build on Linux ppc64(le)
Hello, please review the following fix .
I recently experimented a bit with the minimal VM build on linux x86_64 (--with-jvm-features=minimal --with-jvm-variants=minimal) .
This worked fine .
However when I tried the minimal vm build on linux ppc64 / ppc64le , I noticed that it fails because of a few wrong dependencies .
Thanks to Martin for the advice regarding
Register ic = as_Register(Matcher::inline_cache_reg_encode());
Replacement with
Register ic = R19_inline_cache_reg;
In http://cr.openjdk.java.net/~mbaesken/webrevs/8233078.0/src/hotspot/cpu/ppc/sharedRuntime_ppc.cpp.frames.html
Bug/webrev :
https://bugs.openjdk.java.net/browse/JDK-8233078
http://cr.openjdk.java.net/~mbaesken/webrevs/8233078.0/
Thanks, Matthias
More information about the build-dev
mailing list