Fixing compiler warnings in src/demo/share/jfc

[Marc Hoffmann]

Hi Magnus,

I submitted a signed OCA and will suggest the patch to swing-dev.

I'll come back in case I struggle with the process.

Thanks for your support for my little contribution!
-marc

> On 29. Oct 2019, at 13:21, Magnus Ihse Bursie <magnus.ihse.bursie at oracle.com> wrote:
> 
> Hi,
> 
> Thank you for fixing this, and for your nice workds about the OpenJDK build system! Those warnings have annoyed me to, and I'm glad to see that someone has stepped up to fix them.
> 
> Unfortunately, making a first time contribution to OpenJDK is somewhat cumbersome, since this is a large and very formal project. This page will give you most of the instructions you need: https://openjdk.java.net/contribute <https://openjdk.java.net/contribute>. As a minimum, you need to sign the OCA. Without this, we can unfortunately do nothing more with your patches. :-(
> 
> And as David said, these fixes will need to be approved by folks in swing-dev at openjdk.java.net <mailto:swing-dev at openjdk.java.net>. However, fixing warnings in the build do indeed intersect with build issues, so you feel free to cross-post the discussion here. 
> 
> Let me know if you run into too much friction in the process, and want me to assist you to shepherd these fixes. I know getting your first patch in can be a bit rough.
> 
> /Magnus
> 
> On 2019-10-23 19:59, Marc Hoffmann wrote:
>> MOTIVATION
>> 
>> As a developer of the JaCoCo code coverage library I do lots of JDK builds. JDK
>> builds are simple, fast and produce minimal log output. Nice! What annoys me
>> though are plenty of compiler warnings at the end of the build caused by the
>> example code in src/demo/share/jfc
>> 
>> FIX
>> 
>> I propose a series of 3 patches (based on each other) which fixes all compiler
>> warnings for the demos:
>> 
>> patch1.txt - Fix compiler warnings in demos: raw types
>> patch2.txt - Fix compiler warnings in demos: deprecated APIs
>> patch3.txt - Fix compiler warnings in demos: deprecated Applet APIs
>> 
>> While patch 1 & 2 do not change functionality patch 3 actually removes the
>> Applet versions of some of the demos. The java main versions of the same demos
>> are still intact.
>> 
>> The patches are based on changeset 56699:70e6b0d8db13.
>> 
>> They have been tested from this clone: https://github.com/marchof/jdk/tree/fix-compiler-warnings-in-demos <https://github.com/marchof/jdk/tree/fix-compiler-warnings-in-demos>
>> 
>> RESULT
>> 
>> All compiler warnings on demo code during JDK build are removed
>> 
>> TESTING
>> 
>> I haven't found any automated tests so I manually launched all the demos. From
>> what I can say they are still functional.
>> 
>> SCOPE
>> 
>> I applied minimal changes to remove compiler warnings only. There are many more
>> cleanup opportunities in the demo code. Also there is (dead?) code in
>> src/demo/share/java2d which has similar issues. Both are not on scope of these
>> patches.
>> 
>> NEXT STEPS
>> 
>> I’m have no experience with OpenJDK patches. If you’re interested in getting these warnings fixed please
>> let me know how I can submit these patches properly.
>> 
>> 
>> 
>> 
>