[11u] RFR: 8214311: dtrace gensrc has missing dependencies

Severin Gehwolf sgehwolf at redhat.com
Wed Oct 30 09:08:50 UTC 2019


Hi Christoph,

On Wed, 2019-10-30 at 05:48 +0000, Langer, Christoph wrote:
> Hi Severin,
> 
> backport looks good. Thanks for doing it.

Thanks for the review!

Cheers,
Severin

> Cheers
> Christoph
> 
> > -----Original Message-----
> > From: build-dev <build-dev-bounces at openjdk.java.net> On Behalf Of
> > Severin Gehwolf
> > Sent: Dienstag, 29. Oktober 2019 19:19
> > To: jdk-updates-dev <jdk-updates-dev at openjdk.java.net>
> > Cc: build-dev <build-dev at openjdk.java.net>
> > Subject: [11u] RFR: 8214311: dtrace gensrc has missing dependencies
> > 
> > Hi,
> > 
> > Please review this OpenJDK 11u backport of JDK-8214311. It's an
> > Oracle
> > JDK 11.0.6 feature parity patch. The jdk/jdk patch didn't apply
> > cleanly
> > due to context differences in make/hotspot/gensrc/GensrcDtrace.gmk.
> > That is due to JDK-8211029 not being present in OpenJDK 11u code-
> > base.
> > I have fixed the patch manually, which was quite trivial.
> > 
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8214311
> > webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-
> > 8214311/jdk11/01/webrev/
> > Original changeset: 
> > http://hg.openjdk.java.net/jdk/jdk/rev/7b757120a053
> > 
> > Testing: Building on Linux x86_64 with dtrace enabled. Still works.
> > Unfortunately I don't have a Solaris machine available.
> > 
> > Thoughts?
> > 
> > Thanks,
> > Severin




More information about the build-dev mailing list