RFR: 8230781: Add JTREG_FAILURE_HANDLER_TIMEOUT to control timeout handler timeout

[David Holmes]

On 10/09/2019 10:43 am, Leonid Mesnik wrote:
> Hi
> 
> On 9/9/19 5:12 PM, David Holmes wrote:
>> Hi Leonid,
>>
>> On 10/09/2019 10:03 am, Leonid Mesnik wrote:
>>> Hi
>>>
>>> Could you please review following fix which add 
>>> JTREG_FAILURE_HANDLER_TIMEOUT option to customize timeout handler 
>>> timeout.
>>>
>>> webrev: http://cr.openjdk.java.net/~lmesnik/8230781/webrev.00/
>>
>> In terms of adding the flag the change itself appears okay to me.
>>
>> But what exactly is this timeout-handler timeout? We have enough 
>> issues with the timeout-handler running in response to test timeouts, 
>> let alone an additional timeout on top of that.
>>
> This timeout defines how long jtreg should wait for timeout handler 
> completion. It helps to identify if timeout handler has any hangs during 
> processing. Also it helps jtreg to complete in guaranteed time.  By 
> default this feature  is disabled.  I want to enable it for some stress 
> tests.
> 
> http://openjdk.java.net/jtreg/faq.html#what-do-i-need-to-know-about-test-timeouts 

Okay but what exactly happens with this timeout processing? Let's say 
the timeout handler is trying to run jstack and has hung, and this new 
timeout elapses - what happens? Will the attempt to execute jstack 
abort, or will something try to kill it? Can we end up with an orphaned 
hung jstack process on the machine?

These are really jtreg questions though :)

Cheers,
David

> 
> Leonid
> 
>> Thanks,
>> David
>>
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8230781
>>>
>>> I verified fix locally and with mach5.
>>>
>>> Leonid
>>>