RFR: JDK-8231467: Missing make prerequisite declaration corrupts make dependency files on Windows

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Wed Sep 25 18:59:37 UTC 2019


Looks good to me. 

/Magnus

> 25 sep. 2019 kl. 19:59 skrev Erik Joelsson <erik.joelsson at oracle.com>:
> 
> In JDK-8217728 I introduced a new rule in SetupNativeCompilation which combines all the generated *.d dependency files into one for each link target. This combining currently depends on all the object files being compiled first. On Windows, we sometimes also create a resource file, which also produces a *.d dependency file. This file is not declared as a prerequisite of the combined *.d file, which causes a race between the two.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8231467
> 
> Webrev: http://cr.openjdk.java.net/~erikj/8231467/webrev.01/
> 
> /Erik
> 




More information about the build-dev mailing list