RFR: JDK-8231594: Configure fails on some Linux systems

[Erik Joelsson]

Uploaded new webrev in place with a comment explaining this.

/Erik

On 2019-09-30 08:02, Erik Joelsson wrote:
> On 2019-09-30 02:41, Magnus Ihse Bursie wrote:
>> On 2019-09-28 00:37, Erik Joelsson wrote:
>>> In my recent change JDK-8206125, I introduced a bash conditional 
>>> that checks if a string starts with ~. That check seems to fail on 
>>> some Linux systems unless the ~ is quoted.
>> Do you need the check? The old code, prior to JDK-8206125, 
>> unconditionally made the eval. Maybe that was a safer route? This 
>> feels a bit shaky, and the old code has (afaik) been working okay.
>>
> The check prior to JDK-8206125 only applied to Unix platforms, but in 
> that change I made it also apply to Windows. At the point where it's 
> called, we may still have spaces in the path, and the eval does not 
> work with spaces. If we add quotes to handle spaces in the eval, then 
> any ~ will not be evaluated. Basically we have to choose between 
> supporting spaces or ~ in any one fixup call. By adding the 
> conditional, we get to do so on Windows.
>
> /Erik
>
>> /Magnus
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8231594
>>>
>>> Webrev: http://cr.openjdk.java.net/~erikj/8231594/webrev.01
>>>
>>> /Erik
>>>
>>