RFR (S): 8241947: Minor comment fixes for system property handling

Langer, Christoph christoph.langer at sap.com
Wed Apr 1 15:12:08 UTC 2020


Thanks for the review, Alan.

I'll push it then.

Best regards
Christoph

> -----Original Message-----
> From: Alan Bateman <Alan.Bateman at oracle.com>
> Sent: Mittwoch, 1. April 2020 16:46
> To: Langer, Christoph <christoph.langer at sap.com>; Mandy Chung
> <mandy.chung at oracle.com>; core-libs-dev at openjdk.java.net
> Cc: build-dev <build-dev at openjdk.java.net>
> Subject: Re: RFR (S): 8241947: Minor comment fixes for system property
> handling
> 
> On 31/03/2020 19:57, Langer, Christoph wrote:
> > Hi Mandy,
> >
> > this is a good suggestion. The listing of system properties at the props field
> declaration seems somewhat redundant, given that it already exists more
> exactly and with API normativity in the doc of System::getProperties().
> >
> > So what do you think of this version:
> http://cr.openjdk.java.net/~clanger/webrevs/8241947.1/ ?
> >
> Mandy's suggestion to link to getProperties instead is good. This
> version looks good to me.
> 
> -Alan.


More information about the build-dev mailing list