RFR: JDK-8244009 Separate -Xdoclint options in CompileJavaModules.gmk

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Tue Apr 28 16:30:25 UTC 2020



On 2020-04-28 16:30, Erik Joelsson wrote:
> Looks good, but I would be even happier if you also broke up some of 
> those lines. This sdiff already had me scrolling sideways on my 
> smaller screen.
Is this better? I also fixed some unrelated too long lines. A handful of 
instances did not technically need wrapping, but I did it for all 
DOCLINT instances out of consistency.

WebRev: 
http://cr.openjdk.java.net/~ihse/JDK-8244009-separate-doclint/webrev.02

/Magnus
>
> /Erik
>
> On 2020-04-28 04:43, Magnus Ihse Bursie wrote:
>> Many modules get specialized -Xdoclint flags in 
>> CompileJavaModules.gmk.  Long term, unless these are cleaned up and 
>> normalized, we might want to think about creating a better framework 
>> for handling those (similar to the DISABLE_WARNINGS_*), but as a 
>> short-term solution we could just separate them out to a specialized 
>> variable, to better see what "real" arguments to javac modules are 
>> passing.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8244009
>> WebRev: 
>> http://cr.openjdk.java.net/~ihse/JDK-8244009-separate-doclint/webrev.01
>>
>> /Magnus




More information about the build-dev mailing list