RFR: JDK-8243665 exploded-image-optimize touches module-info.class in all modules

Alan Bateman Alan.Bateman at oracle.com
Wed Apr 29 10:31:27 UTC 2020



On 29/04/2020 10:27, Magnus Ihse Bursie wrote:
> Due to the current design of the AddPackagesAttribute build tool, all 
> module-info.class files will be written to, when the tool is run. This 
> happens whenever at least one module-info.class file has been updated. 
> The end result of this is that if you recompile a single module, *all* 
> modules will be touch, forcing jmod to repackage all of them.
>
> This fix did not initially work, since the jmod generation was 
> non-deterministic, but that has gracefully been fixed by Alan in 
> JDK-8243666.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8243665
> WebRev: 
> http://cr.openjdk.java.net/~ihse/JDK-8243665-fix-AddPackagesAttribute/webrev.01
The indentation should be 4 spaces rather than 2, otherwise the 
Arrays.equals check looks okay. Are you sure you want the "Writing to " 
noise?

-Alan



More information about the build-dev mailing list