RFR: 8244097: make bootcycle-images fails after JDK-8244036

[Erik Joelsson]

On 2020-04-29 04:48, Magnus Ihse Bursie wrote:
> On 2020-04-29 13:23, Magnus Ihse Bursie wrote:
>> On 2020-04-29 13:02, jiefu(傅杰) wrote:
>>> Hi all,
>>>
>>> May I get reviews for this fix?
>>>
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8244097
>> Dang it! I thought I had tested bootcycle-images, but maybe that 
>> wasn't the last iteration of my fix.
>>> Webrev: http://cr.openjdk.java.net/~jiefu/8244097/webrev.00/
>> No, I don't think this is the right way to solve it, by stopping 
>> warnings from being errors. Let me get back to you with another 
>> approach.
> As a short time solution, I suggest amending BOOT_JDK_SOURCETARGET 
> when running bootcycle builds instead.
>
> As a more long term solution, I should probably sit down (at least 
> metaphorically) with someone from the compiler team and make a 
> complete pass over all our javac options. I think this warning ensues 
> from something we're doing incorrect, so we ought to fix it properly 
> instead.
>
> Patch inline:
> diff --git a/make/autoconf/bootcycle-spec.gmk.in 
> b/make/autoconf/bootcycle-spec.gmk.in
> --- a/make/autoconf/bootcycle-spec.gmk.in
> +++ b/make/autoconf/bootcycle-spec.gmk.in
> @@ -59,3 +59,6 @@
>
>  # Pandoc cannot be used without the jjs plugin, which was removed 
> with Nashorn.
>  ENABLE_PANDOC := false
> +
> +# Avoid "warning: [options] system modules path not set in 
> conjunction with -source"
> +BOOT_JDK_SOURCETARGET := $(BOOT_JDK_SOURCETARGET) -Xlint:-options
>
Won't this also break if you configure with a JDK 15 boot JDK, which we 
do allow in configure. If so the -Xlin:-options needs to be added to all 
previous uses of the BOOT_JAVAC compiler setup.

/Erik