RFR: JDK-8251193 bin/idea.sh generating wrong source folders for JVMCI modules

[Andrew Dinn]

On 06/08/2020 16:35, Severin Gehwolf wrote:
> On Thu, 2020-08-06 at 16:01 +0100, Maurizio Cimadamore wrote:
>> The basic fix looks good, I'm wondering, however, if we would only want 
>> to enable sources which match the current configuration? E.g. not add 
>> the sources for aarch64 if building on linux? But if we build all these 
>> modules regardless, then it's ok to add them all.
> 
> Looks like on an x86_64 Linux build aarch64 classes get compiled into
> the module(s) as well:
> 
> $ find build/linux-x86_64-server-release/jdk/modules/jdk.internal.vm.ci | grep aarch64
> build/linux-x86_64-server-release/jdk/modules/jdk.internal.vm.ci/jdk/vm/ci/aarch64
  . . .
Well, those classes could perhaps be stripped from (or just not
installed in) the module set but this is about sources.

Idea really needs to know where the AArch64 sources are even when
running on x86_64 (and vice versa). Dev work on shared + x86_64-specific
code can also require making compatible changes to AArch64-specific classes.

regards,


Andrew Dinn
-----------
Red Hat Distinguished Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill