RFR: JDK-8251399 JDK-8248701 had incorrect indentation

Erik Joelsson erik.joelsson at oracle.com
Tue Aug 11 13:02:48 UTC 2020


Looks good.

/Erik

On 2020-08-11 05:43, Magnus Ihse Bursie wrote:
> The fix for JDK-8248701 did not start with a tab, despite being part 
> of a recipe. While this is technically not required for continuted 
> lines, we have as a code rule that all recipe lines should start with 
> a tab.
>
> Webrev (and inline patches for that matter) sucks at showing this 
> properly. Check the patch file if you want to verify that spaces are 
> replaced with a tab. :-)
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8251399
> WebRev: 
> http://cr.openjdk.java.net/~ihse/JDK-8251399-fix-whitespace-in-Modules/webrev.01
>
> /Magnus



More information about the build-dev mailing list