RFR: JDK-8251533 MacOS build of libjimage explicitly adds C++ standard library
Erik Joelsson
erik.joelsson at oracle.com
Thu Aug 13 13:22:52 UTC 2020
Looks good.
In the ADLC case, it seemed to be needed when linking with gcc instead
of clang.
/Erik
On 2020-08-13 05:00, Magnus Ihse Bursie wrote:
> From the bug report:
>
> In CoreLibraries.gmk we have
>
> $(eval $(call SetupJdkLibrary, BUILD_LIBJIMAGE, \
> ...
> ???LIBS_unix := -ljvm -ldl $(LIBCXX), \
> ???LIBS_macosx := -lc++, \
>
> I think the LIBS_macosx line should not be needed. Other similar
> places don't seem to do that. If it were necessary to explicitly add
> the C++ standard library to the link command, that would be better
> done by setting up LIBCXX.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8251533
> WebRev:
> http://cr.openjdk.java.net/~ihse/JDK-8251533-libjimage-links-with-lc++/webrev.01
>
> /Magnus
More information about the build-dev
mailing list