RFR: JDK-8256950: Add record attribute support to symbol generator CreateSymbols [v3]

Jan Lahoda jlahoda at openjdk.java.net
Tue Dec 1 12:13:56 UTC 2020


On Tue, 1 Dec 2020 02:18:18 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixing tests on Windows - normalizing line endings.
>
> Looks mostly OK; some minor comments inline.

Thanks for the comments Jon! I've tried to resolve them here:
https://github.com/openjdk/jdk/pull/1480/commits/9ab7153a4f301dc77c02dd1ffda247cf7cdeb5ea

-------------

PR: https://git.openjdk.java.net/jdk/pull/1480



More information about the build-dev mailing list