RFR: JDK-8257547: Handle multiple prereqs on the same line in deps files [v2]
    Tim Bell 
    tbell at openjdk.java.net
       
    Wed Dec  2 22:37:58 UTC 2020
    
    
  
On Wed, 2 Dec 2020 21:41:26 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> test/make/TestFixDepsFile.gmk line 60:
>> 
>>> 58: 	$(ECHO) " $(WORKSPACE_ROOT)/bar/baz \\" >> $(DEPS_FILE).expected
>>> 59: 	$(ECHO) " /foo/baz" >> $(DEPS_FILE).expected
>>> 60: 	$(DIFF) $(DEPS_FILE).expected $(DEPS_FILE)
>> 
>> Does this need to be:
>> $(DIFF) $(DEPS_FILE).expected $(DEPS_FILE).tmp
>
> No, the fix-deps-file macro takes file.tmp as input and outputs into file, so $(DEPS_FILE) is the output file from the macro in this case.
OK
-------------
PR: https://git.openjdk.java.net/jdk/pull/1548
    
    
More information about the build-dev
mailing list