RFR: 8256657: Add cross-compiled build for Windows+Arm64 to submit workflow [v4]
Aleksey Shipilev
shade at openjdk.java.net
Tue Dec 8 07:02:14 UTC 2020
On Mon, 7 Dec 2020 19:34:26 GMT, Bernhard Urban-Forster <burban at openjdk.org> wrote:
>> This adds the cross-compiled build only, as no Windows+Arm64 machines are available on GitHub Action that we could use to run the tests.
>>
>> Due to cross-compilation a build JDK is required. Initially I added EA builds to be downloaded from https://jdk.java.net/16/ and used for that, but then I saw how @shipiliv attempted it for the linux cross-compilation builds in https://github.com/openjdk/jdk/pull/1147. That is using the JDK image produced by the x64 variant. This however add more stress to the "critical path", as now two more jobs depend on the x64 build first.
>>
>> Let's see how it works out in the long-run. A Windows+AArch64 build takes 40-50min.
>
> Bernhard Urban-Forster has updated the pull request incrementally with one additional commit since the last revision:
>
> merge mistakes
Minor nits.
.github/workflows/submit.yml line 954:
> 952: --with-boot-jdk="$env:BOOT_JDK"
> 953: --with-jtreg="$env:JT_HOME"
> 954: --with-gtest="$env:GTEST"
Ditto for `--with-jtreg`, `--with-gtest`.
.github/workflows/submit.yml line 956:
> 954: --with-gtest="$env:GTEST"
> 955: --with-default-make-target="hotspot"
> 956: --enable-jtreg-failure-handler
Ditto for `--enable-jtreg-failure-handler`.
.github/workflows/submit.yml line 930:
> 928: name: transient_jtreg_${{ needs.prerequisites.outputs.bundle_id }}
> 929: path: ~/jtreg/
> 930: if: steps.jtreg_restore.outcome == 'failure'
Since we are not running tests, and only build hotspot, we can skip jtreg and gtest additions in this job. Saves a few cycles? This would be similar to what "Linux additional" does.
-------------
Marked as reviewed by shade (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/1379
More information about the build-dev
mailing list