RFR: 8258005: JDK build fails with incorrect fixpath script [v2]
Erik Joelsson
erikj at openjdk.java.net
Thu Dec 10 13:40:36 UTC 2020
On Thu, 10 Dec 2020 13:11:47 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> The Leaning Toothpick Syndrome[1] strikes back!
>>
>> In the fixpath shell script wrapper, we transform single `` to `\`, to make them correctly escaped. Unfortunately, the bas variable substitution pattern I used were missing a `/`, so it only replaced the first backslash, not all of them.
>>
>> Thanks to @vidmik for analysis and fix!
>>
>> [1] https://en.wikipedia.org/wiki/Leaning_toothpick_syndrome
>
> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>
> Also update second instance of WINENV_ROOT backslash rewrite
Marked as reviewed by erikj (Reviewer).
-------------
PR: https://git.openjdk.java.net/jdk/pull/1731
More information about the build-dev
mailing list