RFR: JDK-8185734: [Windows] Structured Exception Catcher missing around gtest execution

[Thomas Stuefe]

On Tue, 15 Dec 2020 08:20:54 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> Build changes look good.
> 
> I left a note on the hotspot code; feel free to ignore it if you want. :)
> 
> I agree with your assessment that restoring gtest to the code base would make life simpler. I'm not sure what needs to be done to do that; I suppose it needs someone to write and implement a JBS feature, and to publicly acknowledge that they intent to spend the time needed to keep it up to date with upstream going forward.

Yes, and unfortunately I cannot do this - I think this has to be driven from inside Oracle.

> 
> (I also agree with your assessment on VEH replacing SEH, as my recollection of working with the runtime system on JRockit was that VEH was superior for the needs of a VM, and much closer to the posix signal model.)

I also agree. @luhenry 's work convinced me, lets see when it bears fruit.

Cheers, Thomas

-------------

PR: https://git.openjdk.java.net/jdk/pull/1757