RFR: 8258411: Move module set configuration from Modules.gmk to conf dir [v2]
Magnus Ihse Bursie
ihse at openjdk.java.net
Wed Dec 16 13:54:56 UTC 2020
On Wed, 16 Dec 2020 10:21:08 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> @mlchung The entire point of this exercise is to *not* have hard-coded lists of modules in make files...
>>
>> Having hard-coded lists have come back to bite us, time after time again. We try to auto-discover everything that is possible. For these sets of modules, however, auto-discovery is not possible since these lists *define* what we mean by e.g. platform modules or an interim image.
>
> The update to JRE_MODULES in Images.gmk resolves my comment above. However, the naming for the configuration is still a bit odd, e.g. module-sets-classloaders.conf should be something like module-loader-map.conf as used to generate ModuleLoaderMap.java in the build.
@AlanBateman I don't have a problem with renaming the conf files, I just did not know what you wanted them to be called. :-) I renamed `module-sets-classloaders.conf` to `module-loader-map.conf`. Based on this, I rename the other two files `javadoc-modules.conf` and `build-module-sets.conf`, respectively. I hope this is okay. Otherwise, please just let me know what you think they should be called.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1781
More information about the build-dev
mailing list