RFR: 8258411: Move module set configuration from Modules.gmk to conf dir [v2]

Mandy Chung mchung at openjdk.java.net
Wed Dec 16 17:10:03 UTC 2020


On Wed, 16 Dec 2020 14:40:14 GMT, Alan Bateman <alanb at openjdk.org> wrote:

> javadoc-modules.conf is probably okay although someone finding this in the repo might initially think it's the configuration for the javadoc modules. That plus it sets DOCS_MODULES, so maybe it should be apidocs-modules.conf.

I'm okay with apidocs-modules.conf or docs-modules.conf.   It's good to match the make target name which makes it easier to understand what this configuration is for.

> module-loader-map.conf works as the configuration file that defines BOOT_MODULES and PLATFORM_MODULES. I think AGGREGATOR_MODULES should be dropped and "java.se" added to PLATFORM_MODULES. If I remember correctly, this was separated out in JDK 9 and 10 because of the java.se.ee aggregator module (that one was removed in Java 11 by JEP 320).

module-loader-map.conf works for me too.   We can drop AGGREGATOR_MODULES  since java.se is the sole aggregator module in JDK now.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1781



More information about the build-dev mailing list