[jdk16] RFR: JDK-8247994: Localize javadoc search [v3]
Jonathan Gibbons
jjg at openjdk.java.net
Thu Dec 17 16:39:17 UTC 2020
> This is for JDK16, as a precursor to fixing JDK-8258002.
>
> While it is good to be using localized strings in the generated output, the significance for JDK-8258002 is that the strings are now obtained from a resource file, and not hardcoded in JavaScript file itself.
>
> The source file `search.js` is renamed to `search.js.template`, and (unlike other template files) is copied as-is into the generated image. The values in the template are resolved when javadoc is executed, depending on the locale in use at the time. Because of the change in the file's extension, two makefiles are updated to accommodate the new extension: one is for the "interim" javadoc used to generate the API docs; the other is for the primary javadoc in the main JDK image.
Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision:
Address review comment
-------------
Changes:
- all: https://git.openjdk.java.net/jdk16/pull/16/files
- new: https://git.openjdk.java.net/jdk16/pull/16/files/ec111185..1a406f35
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk16&pr=16&range=02
- incr: https://webrevs.openjdk.java.net/?repo=jdk16&pr=16&range=01-02
Stats: 3 lines in 2 files changed: 0 ins; 1 del; 2 mod
Patch: https://git.openjdk.java.net/jdk16/pull/16.diff
Fetch: git fetch https://git.openjdk.java.net/jdk16 pull/16/head:pull/16
PR: https://git.openjdk.java.net/jdk16/pull/16
More information about the build-dev
mailing list