RFR: 8258856: VM build without C1/C2 fails after JDK-8243205 [v2]

Hao Sun github.com+16932759+shqking at openjdk.java.net
Wed Dec 23 09:28:11 UTC 2020


> The declaration sites for JVM flags were changed by JDK-8243205 and the
> subsequent JDK-8258074. As a result, undeclared identifier errors
> occurred while building VM without compiler1 or compiler2 feature.
> 
> Making the corresponding header files included would fix it.
> 
> Note that we have tested locally with this patch, build without C1/C2 succeeded on Linux X86/AArch64 machines.

Hao Sun has updated the pull request incrementally with one additional commit since the last revision:

  Use JVMCI compilation condition and remove redundant header
  
  Check the compilation condition INCLUDE_JVMCI before trying to include
  the header file, i.e. jvmci_globals.hpp, for stubGenerator_x86_64.cpp
  
  In jvmciCompilerToVMInit.cpp, remove the redundant header
  jvmci_globals.hpp since it is already included by compiler_globals.hpp
  
  Change-Id: I8858d4ca94b6d12396db6bbebf226b351b5f230a
  CustomizedGitHooks: yes

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/1876/files
  - new: https://git.openjdk.java.net/jdk/pull/1876/files/22cec1dd..b0bb2de2

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1876&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1876&range=00-01

  Stats: 5 lines in 2 files changed: 3 ins; 2 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1876.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1876/head:pull/1876

PR: https://git.openjdk.java.net/jdk/pull/1876



More information about the build-dev mailing list