RFR: 8258856: VM build without C1/C2 fails after JDK-8243205 [v2]
    Hao Sun 
    github.com+16932759+shqking at openjdk.java.net
       
    Wed Dec 23 10:00:58 UTC 2020
    
    
  
On Wed, 23 Dec 2020 09:33:55 GMT, Jie Fu <jiefu at openjdk.org> wrote:
>> Hao Sun has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use JVMCI compilation condition and remove redundant header
>>   
>>   Check the compilation condition INCLUDE_JVMCI before trying to include
>>   the header file, i.e. jvmci_globals.hpp, for stubGenerator_x86_64.cpp
>>   
>>   In jvmciCompilerToVMInit.cpp, remove the redundant header
>>   jvmci_globals.hpp since it is already included by compiler_globals.hpp
>>   
>>   Change-Id: I8858d4ca94b6d12396db6bbebf226b351b5f230a
>>   CustomizedGitHooks: yes
>
> src/hotspot/share/compiler/oopMap.cpp line 32:
> 
>> 30: #include "compiler/oopMap.hpp"
>> 31: #include "gc/shared/collectedHeap.hpp"
>> 32: #include "jvmci/jvmci_globals.hpp"
> 
> Also #if INCLUDE_JVMCI here?
Thanks for pointing this out. Agree. Will add soon.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1876
    
    
More information about the build-dev
mailing list