RFR: 8258856: VM build without C1/C2 fails after JDK-8243205 [v3]

David Holmes dholmes at openjdk.java.net
Thu Dec 24 06:20:58 UTC 2020


On Wed, 23 Dec 2020 18:36:54 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Hao Sun has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use JVMCI compilation condition for oopMap.cpp
>>   
>>   Check the compilation condition INCLUDE_JVMCI before trying to include
>>   the header file, i.e. jvmci_globals.hpp, for oopMap.cpp
>>   
>>   Change-Id: I9885291d9f971984d83942669a22ee030722a206
>>   CustomizedGitHooks: yes
>
> Good.

Just an observation but it seems to me that if we are not including C1 or C2 in a build (ie interpreter-only) then really the build system should not be building the source files that had to be fixed.

David

-------------

PR: https://git.openjdk.java.net/jdk/pull/1876



More information about the build-dev mailing list