RFR [XS]: 8238530: OPT_SPEED_SRC list misses some files with cpu-dependend file names

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Wed Feb 5 09:58:39 UTC 2020


On 2020-02-05 10:49, Baesken, Matthias wrote:
> Hello,  please review this small change .
>
> The OPT_SPEED_SRC list (for files to be built optimized for speed) in JVMFeatures.gmk includes a few files with cpu-dependend names for arm
> but misses the corresponding files for other cpus (e.g. frame_arm.cpp).  The change adds those files .
>
> Bug/webrev :
>
> https://bugs.openjdk.java.net/browse/JDK-8238530
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8238530.0/
(cc:ing our resident optimization expert Claes)

As usual, Oracle does not care much about ppc, s390 and aarch64. You can 
optimize them however you want. :)

But you have also added frame_x86.cpp and icache_x86.cpp. How does this 
affect performance and correctness on the x64 platform? I'd like you to 
either answer that question, or remove the x86 files from this patch. 
Changes in optimization in frame files sounds like scary stuff without 
proper verification.

/Magnus
>
> Best Regards, Matthias
>




More information about the build-dev mailing list