RFR: JDK-8218480 Automatically add -Werror in FLAGS_COMPILER_CHECK_ARGUMENTS

Erik Joelsson erik.joelsson at oracle.com
Wed Feb 5 14:22:37 UTC 2020


Looks good!

/Erik

On 2020-02-05 03:03, Magnus Ihse Bursie wrote:
> When calling FLAGS_COMPILER_CHECK_ARGUMENTS or any of its variants, we 
> almost always need to add -Werror to the set of arguments to check as 
> otherwise we would not get a failure for unsupported arguments. This 
> should be added automatically by the macro instead.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8218480
> WebRev: 
> http://cr.openjdk.java.net/~ihse/JDK-8218480-fix-FLAGS_COMPILER_CHECK_ARGUMENTS/webrev.01
>
> /Magnus



More information about the build-dev mailing list