RFR: JDK-8213185 Properly handle run-test-prebuilt -> test-prebuilt migration

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Tue Feb 11 13:08:29 UTC 2020


On 2/10/20 6:07 PM, Erik Joelsson wrote:
> The webrev is empty.
Ouch. :( I've recently reinstalled my machine, and apparently not all 
tooling is working as before. I'm sorry I didn't notice that.

Here's a new attempt, this time I've verified that it is non-empty. :-)

WebRev: 
http://cr.openjdk.java.net/~ihse/JDK-8213185-fix-run-test-prebuilt-leftovers/webrev.02

/Magnus

>
> /Erik
>
> On 2020-02-10 00:09, Magnus Ihse Bursie wrote:
>> In JDK-8213184, a rushed revert was pushed to stop breaking CI 
>> builds. A long-term solution is needed, where test-prebuilt can be 
>> restored to jib-profiles.js. This will require the run-test-prebuilt 
>> top-level make target in Help.gmk to be updated as well. Also, 
>> Help.gmk should really change name to signify that it's not just help 
>> targets, but all global targets (some definitely more significant!)
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8213185
>> WebRev: 
>> http://cr.openjdk.java.net/~ihse/JDK-8213185-fix-run-test-prebuilt-leftovers/webrev.01
>>
>> /Magnus




More information about the build-dev mailing list