RFR: 8199138: Add RISC-V support to Zero
Aleksey Shipilev
shade at redhat.com
Wed Feb 12 16:51:32 UTC 2020
On 2/12/20 5:14 PM, John Paul Adrian Glaubitz wrote:
>> [1] http://cr.openjdk.java.net/~glaubitz/8199138/webrev.00/
Neat. Looks good to me.
Minor nits in os_linux.cpp:
*) Can you move the comment to the #define line, as it is done in the similar blocks in the same file?
1854 #ifndef EM_RISCV /* RISCV */
1855 #define EM_RISCV 243
1856 #endif
*) I believe this one is sorted alphabetically, so RISCV should be between __powerpc64__ and S390?
- AARCH64, ALPHA, ARM, AMD64, IA32, IA64, M68K, MIPS, MIPSEL, PARISC, __powerpc__,
__powerpc64__, S390, SH, __sparc
+ AARCH64, ALPHA, ARM, AMD64, IA32, IA64, M68K, MIPS, MIPSEL, PARISC, __powerpc__,
__powerpc64__, S390, SH, __sparc, RISCV
--
Thanks,
-Aleksey
More information about the build-dev
mailing list