RFR: 8239001: Hotspot build broken on linux-sparc after 8238281
John Paul Adrian Glaubitz
glaubitz at physik.fu-berlin.de
Tue Feb 18 16:07:16 UTC 2020
On 2/18/20 4:55 PM, Kim Barrett wrote:
> Nope. That unnecessarily pollutes the global namespace with “dummy_regs”.
>
> The dummy declaration should be in the RegistersForDebugging class as I suggested earlier.
> But you say that “doesn’t work”. I thought perhaps that meant I’d made was a mistake in the
> code snippet I’d sent, but that seems to work for me. So what do you mean by “doesn’t work”?
Ah, I completely missed that mail and the code snippet. Sorry.
I forgot to use a reference type when I tried the definition within the class
which is why it failed for me. I will test the proper approach and post a
patch in a few minutes.
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - glaubitz at debian.org
`. `' Freie Universitaet Berlin - glaubitz at physik.fu-berlin.de
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
More information about the build-dev
mailing list