RFR: JDK-8239789 Follow-up on JVM feature rewrite

[Magnus Ihse Bursie]

On 2020-02-21 17:03, John Paul Adrian Glaubitz wrote:
> On 2/21/20 4:36 PM, Magnus Ihse Bursie wrote:
>> On 2020-02-21 16:15, Erik Gahlin wrote:
>>> jfr should be JDK Flight Recorder.
>> Thanks, I should have checked and not guessed. :)
>>
>> I updated the code but will not send out a new webrev.
> Shouldn't "deprecated-ports" be parts of that list as well?
No, it's not handled as a JVM feature. Not all configure flags affecting 
the build are considered JVM features -- only the ones that affects what 
(and in certain cases how) the JVM is built.

The configure flags all have different purposes. I'm thinking of them 
like roughly falling into these different buckets:

1) external dependencies/tools
    Examples are: native compiler, boot jdk, external libraries and 
header files -- stuff that we need to be able to build, and that we need 
to locate on the build system.

2) build behavior/performance
   Examples are: setting default make target or number of jobs, support 
for precompiled headers, ccache, debug symbol output,

3) customization
   Examples are: version string, vendor name, macOS bundle base name, 
copyright year, cacerts

4) testing and other non-build settings
   Examples are: hotspot gtest, jtreg, etc

5) product features
   Examples are: JVM features (dtrace, jvmti, jfr, etc), static build, 
unlimited crypto, etc

Bypassing the check for deprecated ports belongs to bucket 2. JVM 
features belong to bucket 5.

/Magnus