RFR: JDK-8239789 Follow-up on JVM feature rewrite

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Tue Feb 25 08:43:46 UTC 2020


On 2020-02-24 13:41, Per Liden wrote:
> You forgot to change "ZGC garbage collector" -> "Z garbage collector".
That's very diligent of you. :-) However, I didn't forgot -- I published 
the webrev just before your comment about s/ZGC/Z/, and as I said, I 
will fix this before pushing (as I now have).

/Magnus

>
> /Per
>
> On 2/24/20 9:53 AM, Magnus Ihse Bursie wrote:
>> On 2020-02-21 16:36, Magnus Ihse Bursie wrote:
>>> On 2020-02-21 16:15, Erik Gahlin wrote:
>>>> jfr should be JDK Flight Recorder.
>>> Thanks, I should have checked and not guessed. :)
>>>
>>> I updated the code but will not send out a new webrev.
>>
>> Actually, I am sending out a new webrev, just to make sure I do this 
>> by the book. :)
>>
>> WebRev: 
>> http://cr.openjdk.java.net/~ihse/JDK-8239789-jvm-features-followup/webrev.02 
>>
>>
>> Changes since last webrev:
>>
>> * Fixed expansion of JFR
>> * Replaced patsubst with m4_bpatsubst in UTIL_ALIASED_ARG_ENABLE
>> * Merged with JDK-8239708, meaning changes in basics.m4 moved to 
>> util.m4.
>>
>> /Magnus
>>
>>
>>>
>>> /Magnus
>>>
>>>>
>>>> Erik
>>>>
>>>> On 2020-02-21 16:05, Magnus Ihse Bursie wrote:
>>>>> The JVM feature rewrite was actually somewhat of a step backwards 
>>>>> in terms of presenting information for the user what different 
>>>>> configure arguments do.
>>>>>
>>>>> I've compensated for this by making it far better! :) Now we get a 
>>>>> list like this:
>>>>>
>>>>>   aot                     enable ahead of time compilation (AOT)
>>>>>   cds                     enable class data sharing (CDS)
>>>>>   compiler1               enable hotspot compiler C1
>>>>>   compiler2               enable hotspot compiler C2
>>>>>   dtrace                  enable dtrace support
>>>>>   epsilongc               include the epsilon (no-op) garbage 
>>>>> collector
>>>>>   g1gc                    include the G1 garbage collector
>>>>>   graal                   enable Graal (jdk.internal.vm.compiler)
>>>>>   jfr                     enable Java Flight Recorder (JFR)
>>>>>   jni-check               enable -Xcheck:jni support
>>>>>   jvmci                   enable JVM Compiler Interface (JVMCI)
>>>>>   jvmti                   enable Java Virtual Machine Tool 
>>>>> Interface (JVM TI)
>>>>>   link-time-opt           enable link time optimization
>>>>>   management              enable java.lang.management API support
>>>>>   minimal                 support building variant 'minimal'
>>>>>   nmt                     include native memory tracking (NMT)
>>>>>   parallelgc              include the parallel garbage collector
>>>>>   serialgc                include the serial garbage collector
>>>>>   services                enable diagnostic services and client 
>>>>> attaching
>>>>>   shenandoahgc            include the Shenandoah garbage collector
>>>>>   static-build            build static library instead of dynamic
>>>>>   vm-structs              export JVM structures to the 
>>>>> Serviceablility Agent
>>>>>   zero                    support building variant 'zero'
>>>>>   zgc                     include the ZGC garbage collector
>>>>>
>>>>> Also, I missed using the recommended m4_ prefix on some m4 
>>>>> functions. This patch also corrects this.
>>>>>
>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8239789
>>>>> WebRev: 
>>>>> http://cr.openjdk.java.net/~ihse/JDK-8239789-jvm-features-followup/webrev.01 
>>>>>
>>>>>
>>>>> /Magnus
>>>
>>




More information about the build-dev mailing list