macOS build success but codesign fail on macOS 10.13.5 or older

[Erik Joelsson]

On 2020-02-27 06:16, Magnus Ihse Bursie wrote:
> I don't think it should be a fatal error. If you have a codesign 
> binary on your path that does not support --option runtime, you should 
> still be able to build, but not sign. Change it to a warning, and let 
> the user continue without CODESIGN.
>
My interpretation of this patch is that the new check is only performed 
if a valid --with-macosx-codesign-identity was provided, so the user has 
clearly requested signing to be performed. In that case I agree that it 
should error out.

/Erik