RFR [XS]: 8237374: configuring with --with-jvm-variants=minimal,server makes cds disappear in server

[Erik Joelsson]

That looks good.

/Erik


On 2020-01-21 06:45, Baesken, Matthias wrote:
> Hi Erik, new webrev :
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8237374.1/
>
> Best regards, Matthias
>
> -----Original Message-----
> From: Erik Joelsson <erik.joelsson at oracle.com>
> Sent: Freitag, 17. Januar 2020 15:18
> To: Baesken, Matthias <matthias.baesken at sap.com>; 'build-dev at openjdk.java.net' <build-dev at openjdk.java.net>; 'hotspot-dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>
> Subject: Re: RFR [XS]: 8237374: configuring with --with-jvm-variants=minimal,server makes cds disappear in server
>
> Hello Matthias,
>
> Using BUILDING_MULTIPLE_JVM_VARIANTS as condition is clever and happens
> to coincide with the set of variants that also support CDS, but I would
> say this correlation is incidental. I would still prefer an explicit
> test for if any of the variants that do support CDS is in the set of
> variants being built. This will make it much easier to read and
> understand the logic. Simply:
>
> if ! HOTSPOT_CHECK_JVM_VARIANT(server) && !
> HOTSPOT_CHECK_JVM_VARIANT(client); then
>     ENABLE_CDS="false"
>     ...
>
> /Erik
>
>