RFR: JDK-8237879: make 4.3 breaks build

[Magnus Ihse Bursie]

On 2020-01-28 17:15, Erik Joelsson wrote:
> On 2020-01-28 03:05, Magnus Ihse Bursie wrote:
>> On 2020-01-28 00:13, Erik Joelsson wrote:
>>> Please review this fix to make the build compatible with GNU make 
>>> 4.3. See bug for details on the fix, but this change basically adds 
>>> an empty rule like this for the example failure:
>>>
>>> /localhome/git/jdk-sandbox/open/build/linux-x86_64-server-release/buildtools/langtools_tools_classes/_the.BUILD_TOOLS_LANGTOOLS.vardeps: 
>>>
>>>
>>> With this change I'm able to build with make 4.3 and 
>>> DependOnVariable is still behaving as expected.
>>>
>>> Webrev: http://cr.openjdk.java.net/~erikj/8237879/webrev.01/index.html
>> Oh, we've solved this in parallel. :-&
>>
>> Actually, I think I prefer my fix:
>>
>> http://cr.openjdk.java.net/~ihse/JDK-8237879-make-4-3-include-is-broken/webrev.01 
>>
>>
>> I think it more clearly captures the issue, rather than adding a 
>> "magic" workaround.
>>
> Ah, it's the -include that was the issue. I didn't get that far. Then 
> yes, your solution is better (if you break that long line)!
I got tired of the code duplication of "$(call DependOnVariableFileName, 
$1, $2)". Here's a new webrev with shorter lines,
and hopefully better readability overall:

http://cr.openjdk.java.net/~ihse/JDK-8237879-make-4-3-include-is-broken/webrev.02/make/common/MakeBase.gmk.udiff.html

/Magnus

>
> /Erik
>
>> /Magnus
>>
>>
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8237879
>>>
>>> /Erik
>>>
>>