RFR & sponsor: 8248701: On Windows generated modules-deps.gmk can contain backslash-r (CR) characters

Erik Joelsson erik.joelsson at oracle.com
Wed Jul 8 12:19:54 UTC 2020


Looks good, I will sponsor it.

/Erik

On 2020-07-08 03:22, Andrew Leonard wrote:
> Hi,
>
> Please can I request a review and sponsor to push the following simple fix
> to Modules.gmk:
> http://cr.openjdk.java.net/~aleonard/8248701/webrev.00/
> for bug: https://bugs.openjdk.java.net/browse/JDK-8248701
>
> which is to cover situations on Windows where a /r(CR) can cause a build
> break due to badly generated make dependency.
>
> Thank you,
> Andrew
>
> Andrew Leonard
> Java Runtimes Development
> IBM Hursley
> IBM United Kingdom Ltd
> internet email: andrew_m_leonard at uk.ibm.com
>
> Unless stated otherwise above:
> IBM United Kingdom Limited - Registered in England and Wales with number
> 741598.
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
>



More information about the build-dev mailing list