RFR: 8249704: UTIL_DEPRECATED_ARG_ENABLE dumps incorrect warning message

[jiefu(傅杰)]

Hi Erik,

Thanks for sharing this knowledge with us.
I'll close this issue as won't fix.

Best regards,
Jie


On 2020/7/20, 9:34 PM, "Erik Joelsson" <erik.joelsson at oracle.com> wrote:

    Hello Jie,
    
    Your change looks fine if you really think this is a problem.
    
    However, in Autoconf all --enable-* options have a corresponding 
    --disable-* (and every --with-* has a --without-*). Always explicitly 
    listing both in all help text would be very cumbersome and I think would 
    need to be applied consistently if desired. We have assumed some basic 
    autoconf knowledge like this when using the configure script, and so we 
    aren't listing both variants. Sometimes we do list the negated version 
    in the help text when that's the more obviously useful option. Perhaps 
    that should have been done in this case as disabling gtest was the more 
    common user option (as enabled was default).
    
    /Erik
    
    On 2020-07-17 23:17, jiefu(傅杰) wrote:
    > Hi all,
    >
    > May I get reviews for this change?
    >
    > JBS:    https://bugs.openjdk.java.net/browse/JDK-8249704
    > Webrev: http://cr.openjdk.java.net/~jiefu/8249704/webrev.00/
    >
    > Thanks a lot.
    > Best regards,
    > Jie