[15] RFR(T) : 8250688 : missed open parenthesis for GTEST_FRAMEWORK_SRC var in Main.gmk

Igor Ignatyev igor.ignatyev at oracle.com
Tue Jul 28 16:10:55 UTC 2020


thanks Erik, pushed to jdk15.

-- Igor

> On Jul 28, 2020, at 8:15 AM, Erik Joelsson <erik.joelsson at oracle.com> wrote:
> 
> Looks good.
> 
> /Erik
> 
> On 2020-07-28 07:51, Igor Ignatyev wrote:
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>> Hi all,
>> 
>> could you please review the one-liner which fixes the typo introduced by 8245610?
>> 
>> patch:
>>> diff -r 31a8f79a7dfe make/Main.gmk
>>> --- a/make/Main.gmk	Tue Jul 28 10:32:57 2020 -0400
>>> +++ b/make/Main.gmk	Tue Jul 28 07:50:42 2020 -0700
>>> @@ -664,7 +664,7 @@
>>>      DEPS := build-test-hotspot-jtreg-graal, \
>>>  ))
>>>  -ifneq ($GTEST_FRAMEWORK_SRC), )
>>> +ifneq ($(GTEST_FRAMEWORK_SRC), )
>>>    $(eval $(call SetupTarget, test-image-hotspot-gtest, \
>>>        MAKEFILE := hotspot/test/GtestImage, \
>>>        DEPS := hotspot, \
>>> 
>> 
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8250688
>> 8245610: https://bugs.openjdk.java.net/browse/JDK-8245610
>> 
>> Thanks,
>> -- Igor




More information about the build-dev mailing list