RFR: 8246256: GenerateLinkOptData should not mutate the interim or bootstrap JDK

[Claes Redestad]

Thanks, Erik!

/Claes

On 2020-06-01 18:04, Erik Joelsson wrote:
> Looks good!
> 
> /Erik
> 
> On 2020-06-01 08:54, Claes Redestad wrote:
>>
>> On 2020-06-01 17:26, Magnus Ihse Bursie wrote:
>>> On 2020-06-01 16:37, Claes Redestad wrote:
>>>> Hi,
>>>>
>>>> the classlist generation mutates the interim JDK, which is usually
>>>> part of the things we build, but can also be an external bootstrap JDK
>>>> that we shouldn't write to. Fix is to explicitly generate the files to
>>>> explicit locations in the build directory.
>>>>
>>>> Sponsoring the fix Fedor suggested here:
>>>>
>>>> https://mail.openjdk.java.net/pipermail/build-dev/2020-May/027537.html
>>>>
>>>> Bug:    https://bugs.openjdk.java.net/browse/JDK-8246256
>>>> Webrev: http://cr.openjdk.java.net/~redestad/8246256/open.00/
>>> Looks good to me.
>>
>> Thanks!
>>
>> In off-list talk with Erik we agreed it would be a good idea to also
>> rename the second $@.raw to $@.raw.2 to avoid overwriting intermediate
>> results:
>>
>> http://cr.openjdk.java.net/~redestad/8246256/open.01/
>>
>> Hope everyone's ok with this small change.
>>
>> /Claes