[11u] RFR(xs): 8247874: Replacement in VersionProps.java.template not working when --with-vendor-bug-url contains '&'

Severin Gehwolf sgehwolf at redhat.com
Fri Jun 19 13:41:38 UTC 2020


Hi,

Could I get a review of this OpenJDK 11 specific patch? This same issue
has been solved in OpenJDK 13 and better with JDK-8223319[1] which
seems an unrelated issue to the fix of this bug. Also, I have tried
applying the JDK 13 patch and it doesn't apply well and would mean some
form of rewrite. I'm not sure this is worth it in this case.

For this reason, I propose to only backport the small part of the
(larger) JDK-8223319 fix which fixes the --with-*vendor-bug-url
functionality when those URLs contain '&'. Since this will be pushed
(if accepted) under a separate bug there shouldn't be any confusion.

Bug: https://bugs.openjdk.java.net/browse/JDK-8247874
webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8247874/01/webrev/

Testing: Manual inspection of generated VersionProps.java and manual
testing of the crash URL.

Thoughts?

Thanks,
Severin

[1] Add copyright footer to specs and man pages
    https://bugs.openjdk.java.net/browse/JDK-8223319




More information about the build-dev mailing list