[11u] RFR: 8189861: Refactor CacheFind

Langer, Christoph christoph.langer at sap.com
Wed Mar 11 09:58:02 UTC 2020


Hi Severin,

thanks for the review.

> > Bug: https://bugs.openjdk.java.net/browse/JDK-8189861
> > Original Change: http://hg.openjdk.java.net/jdk/jdk/rev/e297c7bb6469
> > Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8189861.11u/
> 
> I've compared it to the original change and it looks good except for
> the hunk in make/hotspot/lib/CompileJvm.gmk. Andrew's backport then
> also works for getting the static-libs image built.

So you think we should have the hunk in make/hotspot/lib/CompileJvm.gmk or leave it out?

You should probably also make up your mind on whether it's 11.0.7 or 11.0.8. It applies to both repos and I test it with both. I guess, in the end it depends on how urgent the backport of "JDK-8232748 Build static versions of certain JDK libraries" is.

Best regards
Christoph



More information about the build-dev mailing list